Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ring/basic): coercions of ring_hom.id #8439

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(algebra/ring/basic): coercions of ring_hom.id #8439

wants to merge 1 commit into from

Conversation

alexjbest
Copy link
Member

Two basic lemmas about the identity map as a ring hom, split off from #3292 at @eric-wieser's suggestion.

Open in Gitpod

@alexjbest alexjbest added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 26, 2021
@alexjbest alexjbest added the awaiting-review The author would like community review of the PR label Jul 26, 2021
@jcommelin jcommelin changed the title feat(algebra/ring/basic): what happens when you coerce the ring hom id to a monoid hom feat(algebra/ring/basic): coercions of ring_hom.id Jul 27, 2021
jcommelin
jcommelin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2021
bors bot pushed a commit that referenced this pull request Jul 27, 2021
@alexjbest
feat(algebra/ring/basic): coercions of ring_hom.id (#8439)
fb815d7 
Two basic lemmas about the identity map as a ring hom, split off from #3292 at @eric-wieser's suggestion.
@bors
Copy link

bors bot commented Jul 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ring/basic): coercions of ring_hom.id [Merged by Bors] - feat(algebra/ring/basic): coercions of ring_hom.id Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bors bors bot deleted the ring_hom_id_coes branch July 27, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexjbest @eric-wieser @jcommelin