-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(linear_algebra/matrix/general_linear_group): GL(n, R) #8466
Conversation
… contains definition of the general linear group
Here's the lemma you need to close your sorry: /-- Applying `matrix.nonsing_inv` to the coercion is the same as coercing the group inverse. -/
lemma nonsing_inv_coe_eq_coe_inv (A : units (matrix n n R)) : (A : matrix n n R)⁻¹ = ↑(A⁻¹) :=
begin
letI := A.invertible,
exact (inv_eq_nonsing_inv_of_invertible (A : matrix n n R)).symm,
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look at https://leanprover-community.github.io/contribute/style.html#structuring-definitions-and-theorems and reformat your file appropriately? Specifically, you should:
- Indent lemma bodies by two spaces not one
- avoid more than one blank line in a row
- Ensure parameters are always spaced as
(name : type)
, never(name: type )
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors r+ |
added this file which contains definition of the general linear group as well as the subgroup of matrices with positive determinant.
Pull request successfully merged into master. Build succeeded: |
…10900) Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly. This handles: * `Submonoid` * `Subgroup` * `Subsemiring` * `Subring` * `Subfield` * `Submodule` * `Subalgebra` This also moves `Units.posSubgroup` into its own file. The copyright headers are from: * leanprover-community/mathlib#6489 * leanprover-community/mathlib#8466 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…10900) Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly. This handles: * `Submonoid` * `Subgroup` * `Subsemiring` * `Subring` * `Subfield` * `Submodule` * `Subalgebra` This also moves `Units.posSubgroup` into its own file. The copyright headers are from: * leanprover-community/mathlib#6489 * leanprover-community/mathlib#8466 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…10900) Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly. This handles: * `Submonoid` * `Subgroup` * `Subsemiring` * `Subring` * `Subfield` * `Submodule` * `Subalgebra` This also moves `Units.posSubgroup` into its own file. The copyright headers are from: * leanprover-community/mathlib#6489 * leanprover-community/mathlib#8466 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…10900) Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly. This handles: * `Submonoid` * `Subgroup` * `Subsemiring` * `Subring` * `Subfield` * `Submodule` * `Subalgebra` This also moves `Units.posSubgroup` into its own file. The copyright headers are from: * leanprover-community/mathlib#6489 * leanprover-community/mathlib#8466 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
added this file which contains definition of the general linear group as well as the subgroup of matrices with positive determinant.