Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/matrix/general_linear_group): GL(n, R) #8466

Closed
wants to merge 76 commits into from

Conversation

CBirkbeck
Copy link
Collaborator

added this file which contains definition of the general linear group as well as the subgroup of matrices with positive determinant.


Open in Gitpod

… contains definition of the general linear group
@CBirkbeck CBirkbeck added the awaiting-review The author would like community review of the PR label Jul 29, 2021
@bryangingechen bryangingechen changed the title doc(linear_algebra/matrix/general_linear_group): feat(linear_algebra/matrix/general_linear_group): GL(n, R) Jul 29, 2021
@eric-wieser
Copy link
Member

eric-wieser commented Jul 29, 2021

Here's the lemma you need to close your sorry:

/-- Applying `matrix.nonsing_inv` to the coercion is the same as coercing the group inverse. -/
lemma nonsing_inv_coe_eq_coe_inv (A : units (matrix n n R)) : (A : matrix n n R)⁻¹ = ↑(A⁻¹) :=
begin
  letI := A.invertible,
  exact (inv_eq_nonsing_inv_of_invertible (A : matrix n n R)).symm,
end

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at https://leanprover-community.github.io/contribute/style.html#structuring-definitions-and-theorems and reformat your file appropriately? Specifically, you should:

  • Indent lemma bodies by two spaces not one
  • avoid more than one blank line in a row
  • Ensure parameters are always spaced as (name : type), never (name: type )

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 30, 2021
CBirkbeck and others added 6 commits October 1, 2021 17:42
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
src/ring_theory/subsemiring.lean Outdated Show resolved Hide resolved
src/ring_theory/subsemiring.lean Outdated Show resolved Hide resolved
CBirkbeck and others added 9 commits October 2, 2021 13:01
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@CBirkbeck
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 4, 2021
added this file which contains definition of the general linear group as well as the subgroup of matrices with positive determinant.
@bors
Copy link

bors bot commented Oct 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/matrix/general_linear_group): GL(n, R) [Merged by Bors] - feat(linear_algebra/matrix/general_linear_group): GL(n, R) Oct 4, 2021
@bors bors bot closed this Oct 4, 2021
@bors bors bot deleted the general_linear_group branch October 4, 2021 11:23
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Feb 25, 2024
…10900)

Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly.

This handles:
* `Submonoid`
* `Subgroup`
* `Subsemiring`
* `Subring`
* `Subfield`
* `Submodule`
* `Subalgebra`

This also moves `Units.posSubgroup` into its own file.

The copyright headers are from:
* leanprover-community/mathlib#6489
* leanprover-community/mathlib#8466



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
riccardobrasca pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 1, 2024
…10900)

Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly.

This handles:
* `Submonoid`
* `Subgroup`
* `Subsemiring`
* `Subring`
* `Subfield`
* `Submodule`
* `Subalgebra`

This also moves `Units.posSubgroup` into its own file.

The copyright headers are from:
* leanprover-community/mathlib#6489
* leanprover-community/mathlib#8466



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
dagurtomas pushed a commit to leanprover-community/mathlib4 that referenced this pull request Mar 22, 2024
…10900)

Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly.

This handles:
* `Submonoid`
* `Subgroup`
* `Subsemiring`
* `Subring`
* `Subfield`
* `Submodule`
* `Subalgebra`

This also moves `Units.posSubgroup` into its own file.

The copyright headers are from:
* leanprover-community/mathlib#6489
* leanprover-community/mathlib#8466



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Louddy pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 15, 2024
…10900)

Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly.

This handles:
* `Submonoid`
* `Subgroup`
* `Subsemiring`
* `Subring`
* `Subfield`
* `Submodule`
* `Subalgebra`

This also moves `Units.posSubgroup` into its own file.

The copyright headers are from:
* leanprover-community/mathlib#6489
* leanprover-community/mathlib#8466



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants