[Merged by Bors] - feat(algebra/ordered_monoid): add_eq_bot_iff #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bot addition is saturating on the bottom. On the way, typeclass arguments were relaxed to just `[add_monoid α]`, and helper simp lemmas added for `bot`.
pechersky
added
the
awaiting-review
1 task
|
Should this be called |
I think the naming convention is that |
fpvandoorn
reviewed
Aug 2, 2021
fpvandoorn
added
awaiting-author
pechersky
added
awaiting-review
|
bors d+ |
|
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
bot addition is saturating on the bottom. On the way, typeclass arguments were relaxed to just `[add_semigroup α]`, and helper simp lemmas added for `bot`. The iff lemma added (`add_eq_bot`) is not exactly according to the naming convention, but matches the top lemma and related ones in the naming style, so the style is kept consistent. There is an API proof available, but the defeq proof (using the top equivalent) was used based on suggestions.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Vierkantor
pushed a commit
that referenced
this pull request
Aug 2, 2021
bot addition is saturating on the bottom. On the way, typeclass arguments were relaxed to just `[add_semigroup α]`, and helper simp lemmas added for `bot`. The iff lemma added (`add_eq_bot`) is not exactly according to the naming convention, but matches the top lemma and related ones in the naming style, so the style is kept consistent. There is an API proof available, but the defeq proof (using the top equivalent) was used based on suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bot addition is saturating on the bottom. On the way, typeclass arguments
were relaxed to just
[add_semigroup α], and helper simp lemmasadded for
bot.The iff lemma added (
add_eq_bot) is not exactly according to the naming convention, but matches the top lemma and related ones in the naming style, so the style is kept consistent.There is an API proof available, but the defeq proof (using the top equivalent) was used based on suggestions.