Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/partial_sups): complete lattice lemmas #8480

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order/partial_sups): complete lattice lemmas #8480

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jul 31, 2021
@YaelDillies YaelDillies mentioned this pull request Jul 31, 2021
Closed
1 task
eric-wieser
eric-wieser approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+, after adding the sup' lemma (and maybe a reference to it in the docstring since you mention finset.sup)

@bors
Copy link

bors bot commented Jul 31, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 31, 2021
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 1, 2021
@YaelDillies
feat(order/partial_sups): complete lattice lemmas (#8480)
2063a52
@bors
Copy link

bors bot commented Aug 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/partial_sups): complete lattice lemmas [Merged by Bors] - feat(order/partial_sups): complete lattice lemmas Aug 1, 2021
@bors bors bot closed this Aug 1, 2021
@bors bors bot deleted the partial_sups branch August 1, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YaelDillies @eric-wieser