[Merged by Bors] - feat(algebra/floor): notation for nat_floor and nat_ceil #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
eric-wieser
approved these changes
Aug 3, 2021
|
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
eric-wieser
reviewed
Aug 3, 2021
src/algebra/floor.lean
Outdated
| @@ -347,23 +351,25 @@ end | |||
| It is equal to `⌈q⌉` when `q ≥ 0`, and is `0` otherwise. -/ | |||
There was a problem hiding this comment.
I think you should mention the new notation in this docstring.
eric-wieser
reviewed
Aug 3, 2021
src/algebra/floor.lean
Outdated
| @@ -271,72 +273,74 @@ variables {a : α} {n : ℕ} | |||
| It is equal to `⌊q⌋` when `q ≥ 0`, and is `0` otherwise. -/ | |||
There was a problem hiding this comment.
Similarly with this one, `nat_floor x` (notation `⌊x⌋₊`) or similar would be good on the line above this one.
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 3, 2021
We introduce the notations ` ⌊a⌋₊` for `nat_floor a` and `⌈a⌉₊` for `nat_ceil a`, mimicking the existing notations for `floor` and `ceil` (with the `+` corresponding to the recent notation for `nnnorm`).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce the notations
⌊a⌋₊fornat_floor aand⌈a⌉₊fornat_ceil a, mimicking the existing notations forfloorandceil(with the+corresponding to the recent notation fornnnorm).