Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/ordered_field): add inv_le_of_inv_le and inv_lt_of_inv_lt #8565

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 6, 2021

These lemmas need positivity of only one of two variables. Mathlib already had lemmas about ordered multiplicative groups with these names, I appended prime to their names.


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Aug 6, 2021
@kbuzzard
Copy link
Member

kbuzzard commented Aug 6, 2021

LGTM. Nice docstrings! Thanks.

@sgouezel
Copy link
Collaborator

sgouezel commented Aug 9, 2021

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 9, 2021
bors bot pushed a commit that referenced this pull request Aug 9, 2021
…v_lt` (#8565)

These lemmas need positivity of only one of two variables. Mathlib already had lemmas about ordered multiplicative groups with these names, I appended prime to their names.
@bors
Copy link

bors bot commented Aug 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_field): add inv_le_of_inv_le and inv_lt_of_inv_lt [Merged by Bors] - feat(algebra/ordered_field): add inv_le_of_inv_le and inv_lt_of_inv_lt Aug 9, 2021
@bors bors bot closed this Aug 9, 2021
@bors bors bot deleted the inv-le-of-inv-le branch August 9, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants