[Merged by Bors] - chore(linear_algebra/special_linear_group): Cleanup and golf #8569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
hrmacbeth
reviewed
Aug 9, 2021
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
Vierkantor
reviewed
Aug 9, 2021
Vierkantor
added
awaiting-author
…group' into eric-wieser/tidy-special_linear_group
eric-wieser
added
awaiting-review
Vierkantor
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
LGTM, thanks! Since @hrmacbeth already approved this, I'll go ahead and:
bors d+
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
This cleans up a number things in this file: * Many lemmas were duplicated between `↑A` and `⇑A`. This eliminates the latter spelling from all lemmas, and makes it simplify to the former. Unfortunately the elaborator fights us at every step of the way with `↑A`, so we introduce local notation to take the pain away. * Some lemma names did not match the convention established elsewhere * Some definitions can be bundled more heavily than they currently are. In particular, this merges together `to_lin'` and `to_linear_equiv`, as well as `to_GL` and `embedding_GL`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a number things in this file:
↑Aand⇑A. This eliminates the latter spelling from all lemmas, and makes it simplify to the former. Unfortunately the elaborator fights us at every step of the way with↑A, so we introduce local notation to take the pain away.to_lin'andto_linear_equiv, as well asto_GLandembedding_GL.