Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/{continuous_function/bounded, metric_space/algebra}): new mixin classes #8580

Closed
wants to merge 12 commits into from

Conversation

hrmacbeth
Copy link
Member

This PR defines mixin classes has_lipschitz_add and has_bounded_smul which are designed to abstract algebraic properties of metric spaces shared by normed groups/fields/modules and by ℝ≥0.

This permits the bounded continuous functions α →ᵇ ℝ≥0 to be naturally a topological (ℝ≥0)-module, by a generalization of the proof previously written for normed groups/fields/modules.

Frankly, these typeclasses are a bit ad hoc -- but it all seems to work!


Open in Gitpod

@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Aug 8, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 9, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 10, 2021
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't read particularly closely. Happy to merge if no one else gets to it.

@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 18, 2021
bors bot pushed a commit that referenced this pull request Aug 18, 2021
…ew mixin classes (#8580)

This PR defines mixin classes `has_lipschitz_add` and `has_bounded_smul` which are designed to abstract algebraic properties of metric spaces shared by normed groups/fields/modules and by `ℝ≥0`.

This permits the bounded continuous functions `α →ᵇ ℝ≥0` to be naturally a topological (ℝ≥0)-module, by a generalization of the proof previously written for normed groups/fields/modules.

Frankly, these typeclasses are a bit ad hoc -- but it all seems to work!
@bors
Copy link

bors bot commented Aug 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/{continuous_function/bounded, metric_space/algebra}): new mixin classes [Merged by Bors] - feat(topology/{continuous_function/bounded, metric_space/algebra}): new mixin classes Aug 18, 2021
@bors bors bot closed this Aug 18, 2021
@bors bors bot deleted the nnreal-bcf branch August 18, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants