Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/list/perm): perm.permutations #8587

Closed
wants to merge 6 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Aug 9, 2021

This proves the theorem from Zulip:

theorem perm.permutations {s t : list α} (h : s ~ t) : permutations s ~ permutations t := ...

It also introduces a permutations' function which has simpler equations (and indeed, this function is used to prove the theorem, because it is relatively easier to prove perm.permutations' first).

src/data/list/defs.lean Outdated Show resolved Hide resolved
src/data/list/perm.lean Outdated Show resolved Hide resolved
digama0 and others added 2 commits August 9, 2021 03:41
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
src/data/list/perm.lean Outdated Show resolved Hide resolved
src/data/list/perm.lean Outdated Show resolved Hide resolved
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉! Thanks again.

@pechersky, do you have any interest in trying to golf any proofs?

@pechersky
Copy link
Collaborator

LGTM. I will be using these proofs in at least #8170, and likely will made a follow-up PR about count l l.permutations to golf #8494.

@eric-wieser
Copy link
Member

bors d+

It seems this is hitting a random timeout though, so lets not merge until CI passes.

@bors
Copy link

bors bot commented Aug 9, 2021

✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Aug 9, 2021
@eric-wieser
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 10, 2021
bors bot pushed a commit that referenced this pull request Aug 10, 2021
This proves the theorem from [Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/perm.20of.20permutations):

```lean
theorem perm.permutations {s t : list α} (h : s ~ t) : permutations s ~ permutations t := ...
```
It also introduces a `permutations'` function which has simpler equations (and indeed, this function is used to prove the theorem, because it is relatively easier to prove `perm.permutations'` first).
@bors
Copy link

bors bot commented Aug 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/perm): perm.permutations [Merged by Bors] - feat(data/list/perm): perm.permutations Aug 10, 2021
@bors bors bot closed this Aug 10, 2021
@bors bors bot deleted the perm_permutations branch August 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants