[Merged by Bors] - chore(ring_theory): generalize non_zero_divisors lemmas to monoid_with_zero
#8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with_zero` Shall we move this file to the `algebra` namespace sometime soon?
eric-wieser
reviewed
Aug 10, 2021
4 tasks
Co-Authored-By: Eric Wieser <wieser.eric@gmail.com>
Vierkantor
added
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
…with_zero` (#8607) None of the results about `non_zero_divisors` needed a ring structure, just a `monoid_with_zero`. So the generalization is obvious. Shall we move this file to the `algebra` namespace sometime soon?
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
non_zero_divisors lemmas to monoid_with_zeronon_zero_divisors lemmas to monoid_with_zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the results about
non_zero_divisorsneeded a ring structure, just amonoid_with_zero. So the generalization is obvious.Shall we move this file to the
algebranamespace sometime soon?Marking as WIP until everything builds.