Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/basic) : add a small lemma for simplifying a map between equivalent quotient spaces #8640

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/basic) : add a small lemma for simplifying a map between equivalent quotient spaces #8640

wants to merge 8 commits into from

Conversation

Paul-Lez
Copy link
Collaborator

Open in Gitpod

Paul-Lez and others added 5 commits August 11, 2021 11:01
@Paul-Lez
feat(data/equiv/basic): add a small lemma for simplifying map between…
d733778 
… equivalent quotient spaces induced by equivalent relations
@Paul-Lez @eric-wieser
Update src/data/equiv/basic.lean
a0abda2 
Made the changes suggested by eric-weiser

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@Paul-Lez
Added lemma for quotient.congr and quotient.mk
36653d5
@Paul-Lez @eric-wieser
Update src/data/equiv/basic.lean
ba924e1 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@Paul-Lez
feat(linear_algebra/basic): added a small lemma for working with a ma…
6d72a25 
…p between equivalent quotient spaces
@Paul-Lez Paul-Lez added the awaiting-review The author would like community review of the PR label Aug 12, 2021
@eric-wieser
Copy link
Member

Would you mind running git pull origin master then git push to make the already-merged diff go away?

@Paul-Lez
Copy link
Collaborator Author

Would you mind running git pull origin master then git push to make the already-merged diff go away?

Just ran the commands ! The already-merged code doesn't seem to have left though.

@eric-wieser
Copy link
Member

Looks like it's gone to me!

@Paul-Lez
Copy link
Collaborator Author

Looks like it's gone to me!

Ah great !

eric-wieser
eric-wieser approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 14, 2021
bors bot pushed a commit that referenced this pull request Aug 14, 2021
@Paul-Lez @eric-wieser
feat(linear_algebra/basic) : add a small lemma for simplifying a map …
721f571 
…between equivalent quotient spaces (#8640)




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Aug 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/basic) : add a small lemma for simplifying a map between equivalent quotient spaces [Merged by Bors] - feat(linear_algebra/basic) : add a small lemma for simplifying a map between equivalent quotient spaces Aug 14, 2021
@bors bors bot closed this Aug 14, 2021
@bors bors bot deleted the p_dedekind branch August 14, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Paul-Lez @eric-wieser