Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(tactic/norm_cast): assumption_mod_cast should only work on one goal #8649

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix(tactic/norm_cast): assumption_mod_cast should only work on one goal #8649

wants to merge 2 commits into from

Conversation

robertylewis
Copy link
Member

fixes #8438

Open in Gitpod

@robertylewis robertylewis added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Aug 12, 2021
eric-wieser
eric-wieser approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Patch looks like the obvious one, thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 14, 2021
bors bot pushed a commit that referenced this pull request Aug 15, 2021
@robertylewis
fix(tactic/norm_cast): assumption_mod_cast should only work on one go…
4644447 
…al (#8649)

fixes #8438 



Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Aug 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(tactic/norm_cast): assumption_mod_cast should only work on one goal [Merged by Bors] - fix(tactic/norm_cast): assumption_mod_cast should only work on one goal Aug 15, 2021
@bors bors bot closed this Aug 15, 2021
@bors bors bot deleted the fix_assn_mod_cast branch August 15, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assumption_mod_cast does more than it claims, and doesn't match the behaviour of assumption
2 participants
@robertylewis @eric-wieser