[Merged by Bors] - chore(algebra/module): Swap the naming of smul_(left|right)_injective to match the naming guide
#8659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` to match the naming guide
eric-wieser
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
…e` to match the naming guide (#8659) The naming conventions say: > An injectivity lemma that uses "left" or "right" should refer to the argument that "changes". For example, a lemma with the statement `a - b = a - c ↔ b = c` could be called `sub_right_inj`. This corrects the name of `function.injective (λ c : R, c • x)` to be `smul_left_injective` instead of the previous `smul_right_injective`, and vice versa for `function.injective (λ x : M, r • x)`. This also brings it in line with `mul_left_injective` and `mul_right_injective`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
smul_(left|right)_injective to match the naming guidesmul_(left|right)_injective to match the naming guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming conventions say:
This corrects the name of
function.injective (λ c : R, c • x)to besmul_left_injectiveinstead of the previoussmul_right_injective, and vice versa forfunction.injective (λ x : M, r • x).This also brings it in line with
mul_left_injectiveandmul_right_injective.As requested by @ChrisHughes24 in #8618