[Merged by Bors] - feat(algebra/opposites): more scalar action instances #8672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
| @@ -241,6 +241,12 @@ instance semiring.to_module [semiring R] : module R R := | |||
| zero_smul := zero_mul, | |||
| smul_zero := mul_zero } | |||
|
|
|||
| @[priority 910] -- see Note [lower instance priority] | |||
There was a problem hiding this comment.
Is there any motivation for this very specific value?
There was a problem hiding this comment.
I've no idea, I just copied it from the analogous instance for left-multiplication.
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2021
This adds weaker and stronger versions of `monoid.to_opposite_mul_action` for `has_mul`, `monoid_with_zero`, and `semiring`. It also adds an `smul_comm_class` instance.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds weaker and stronger versions of
monoid.to_opposite_mul_actionforhas_mul,monoid_with_zero, andsemiring. It also adds ansmul_comm_classinstance.The motivation here was to help provide the instance in this Zulip thread