[Merged by Bors] - feat(group_action/defs): add missing comp_hom smul instances #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hom`, ring_homs are linear maps
eric-wieser
added
the
awaiting-review
|
The new instances seem to be creating a loop along with instances further down the import hierarchy, see the linting errors. I've been testing a few files by adding the command #eval tactic.get_decl ``smul_comm_class >>= fails_quickly 3000 >>= tactic.tracewhich returns |
|
In fact, running the command in the auto-generated |
|
I think it might be a reducibility issue. I think if I introduce a semireducible def to wrap the smul field then the problem will go away |
eric-wieser
commented
Aug 17, 2021
pechersky
reviewed
Aug 17, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
* The problem was that when writing `@[to_additive] def foo ...` every declaration used in `foo` in namespace `foo` would be additivized without changing the last part of the name. This behavior was intended to translate automatically generated declarations like `foo._proof_1`. However, if `foo` contains a non-internal declaration `foo.bar` and `add_foo.bar` didn't exist yet, it would also create a declaration `add_foo.bar` additivizing `foo.bar`. * This PR changes the behavior: if `foo.bar` has the `@[to_additive]` attribute (potentially with a custom additive name), then we won't create a second additive version of `foo.bar`, and succeed normally. However, if `foo.bar` doesn't have the `@[to_additive]` attribute, then we fail with a nice error message. We could potentially support this behavior, but it doesn't seem that worthwhile and it would require changing a couple low-level definitions that `@[to_additive]` uses (e.g. by replacing `name.map_prefix` so that it only maps prefixes if the name is `internal`). * So far this didn't happen in the library yet. There are currently 5 non-internal declarations `foo.bar` that are used in `foo` where `foo` has the `@[to_additive]` attribute, but all of these declarations were already had an additive version `add_foo.bar`. * These 5 declarations are `[Mon.has_limits.limit_cone, Mon.has_limits.limit_cone_is_limit, con_gen.rel, magma.free_semigroup.r, localization.r]` * This fixes the error in #8707 and resolves the Zulip thread https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.238707.20linter.20weirdness * I also added some documentation / comments to the function `transform_decl_with_prefix_fun_aux`, made it non-private, and rewrote some steps.
eric-wieser
force-pushed
the
eric-wieser/module.comp_hom
branch
from
657c008
to
084ec62
Compare
jcommelin
reviewed
Aug 19, 2021
jcommelin
added
awaiting-author
eric-wieser
added
awaiting-review
jcommelin
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
eric-wieser
added
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
This adds missing `smul_comm_class` and `is_scalar_tower` instances about the `comp_hom` definitions. To resolve unification issues in finding these instances caused by the reducibility of the `comp_hom` defs, this introduces a semireducible def `has_scalar.comp.smul`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing
smul_comm_classandis_scalar_towerinstances about thecomp_homdefinitions.To resolve unification issues in finding these instances caused by the reducibility of the
comp_homdefs, this introduces a semireducible defhas_scalar.comp.smul.I'll follow up with a PR about
ring_hom.to_algebra.