Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(linear_algebra/basic): fix incorrect namespaces #8757

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 19, 2021

Previously there were names in the linear_map namespace which were about linear_equivs.

This moves:

  • linear_map.fun_congr_left to linear_equiv.fun_congr_left
  • linear_map.automorphism_group to linear_equiv.automorphism_group
  • linear_map.automorphism_group.to_linear_map_monoid_hom to linear_equiv.automorphism_group.to_linear_map_monoid_hom

Open in Gitpod

Previously there were names in the `linear_map` namespace which were about linear_equivs.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 19, 2021
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

bors d+

@bors
Copy link

bors bot commented Aug 19, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 19, 2021
@eric-wieser
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 19, 2021
bors bot pushed a commit that referenced this pull request Aug 19, 2021
Previously there were names in the `linear_map` namespace which were about `linear_equiv`s.

This moves:
* `linear_map.fun_congr_left` to `linear_equiv.fun_congr_left`
* `linear_map.automorphism_group` to `linear_equiv.automorphism_group`
* `linear_map.automorphism_group.to_linear_map_monoid_hom` to `linear_equiv.automorphism_group.to_linear_map_monoid_hom`
@bors
Copy link

bors bot commented Aug 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(linear_algebra/basic): fix incorrect namespaces [Merged by Bors] - fix(linear_algebra/basic): fix incorrect namespaces Aug 19, 2021
@bors bors bot closed this Aug 19, 2021
@bors bors bot deleted the eric-wieser/fix-namespaces branch August 19, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants