New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix(linear_algebra/basic): fix incorrect namespaces #8757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were names in the `linear_map` namespace which were about linear_equivs.
eric-wieser
force-pushed
the
eric-wieser/fix-namespaces
branch
from
August 19, 2021 09:04
2c73719
to
8e97df2
Compare
eric-wieser
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
labels
Aug 19, 2021
2 tasks
Vierkantor
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
bors d+
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Aug 19, 2021
bors r+ |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Aug 19, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
Previously there were names in the `linear_map` namespace which were about `linear_equiv`s. This moves: * `linear_map.fun_congr_left` to `linear_equiv.fun_congr_left` * `linear_map.automorphism_group` to `linear_equiv.automorphism_group` * `linear_map.automorphism_group.to_linear_map_monoid_hom` to `linear_equiv.automorphism_group.to_linear_map_monoid_hom`
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
fix(linear_algebra/basic): fix incorrect namespaces
[Merged by Bors] - fix(linear_algebra/basic): fix incorrect namespaces
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
The PR author may merge after reviewing final suggestions.
easy
< 20s of review time. See the lifecycle page for guidelines.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were names in the
linear_map
namespace which were aboutlinear_equiv
s.This moves:
linear_map.fun_congr_left
tolinear_equiv.fun_congr_left
linear_map.automorphism_group
tolinear_equiv.automorphism_group
linear_map.automorphism_group.to_linear_map_monoid_hom
tolinear_equiv.automorphism_group.to_linear_map_monoid_hom