Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finset/pi_induction): induction on Π i, finset (α i) #8794

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/finset/pi_induction): induction on Π i, finset (α i) #8794

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 21, 2021 •
edited by github-actions bot

@urkud
feat(data/finset,order/conditionally_complete_lattice): lemmas about …
8b0e59c 
…`min'/max'`

* add `finset.nonempty.to_set`;
* add lemmas `finset.max'_lt_iff`, `finset.lt_min'_iff`,
  `finset.max'_eq_sup'`, `finset.min'_eq_inf'`;
* rewrite `finset.induction_on_max` without using `finset.card`,
  move one step to `finset.lt_max'_of_mem_erase_max'`;
* add lemmas relating `Sup`/`Inf` of a nonempty finite set in a
  conditionally complete lattice to
 `finset.sup'`/`finset.inf'`/`finset.max'`/`finset.min'`;
* a few more lemmas about `Sup`/`Inf` of a nonempty finite set
  in a conditionally complete lattice / linear order;
* golf the proof of `filter.high_scores`.
@urkud
Merge branch 'master' into finset-pi-ind
5027434
@urkud
feat(data/finset/pi_induction): induction on Π i, finset (α i)
3cae736
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 21, 2021
@urkud urkud added the awaiting-review The author would like community review of the PR label Aug 21, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 22, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@sgouezel
Copy link
Collaborator

can you merge master?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 23, 2021
@urkud
Copy link
Member Author

urkud commented Aug 23, 2021

can you merge master?

Done.

@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 23, 2021
jcommelin
jcommelin approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 26, 2021
bors bot pushed a commit that referenced this pull request Aug 26, 2021
@urkud
feat(data/finset/pi_induction): induction on Π i, finset (α i) (#8794)
eebda45
@bors
Copy link

bors bot commented Aug 26, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 26, 2021
@urkud
feat(data/finset/pi_induction): induction on Π i, finset (α i) (#8794)
080362d
@bors
Copy link

bors bot commented Aug 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finset/pi_induction): induction on Π i, finset (α i) [Merged by Bors] - feat(data/finset/pi_induction): induction on Π i, finset (α i) Aug 26, 2021
@bors bors bot closed this Aug 26, 2021
@bors bors bot deleted the finset-pi-ind branch August 26, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @sgouezel @jcommelin