Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(order/complete_lattice): use is_empty #8796

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(order/complete_lattice): use is_empty #8796

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 21, 2021

  • change set.univ_eq_empty_iff to use is_empty;
  • rename set.range_eq_empty to set.range_eq_empty_iff;
  • add new set.range_eq_empty, it assumes [is_empty α];
  • combine supr_of_empty, supr_of_empty', and supr_empty into supr_of_empty, same for infi;
  • replace csupr_neg with csupr_of_empty and csupr_false;
  • adjust some proofs to use casesI is_empty_of_nonempty α instead of by_cases h : nonempty α.

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Aug 21, 2021
jcommelin
jcommelin approved these changes Aug 21, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 21, 2021
bors bot pushed a commit that referenced this pull request Aug 21, 2021
@urkud
refactor(order/complete_lattice): use is_empty (#8796)
57e127a 
* change `set.univ_eq_empty_iff` to use `is_empty`;
* rename `set.range_eq_empty` to `set.range_eq_empty_iff`;
* add new `set.range_eq_empty`, it assumes `[is_empty α]`;
* combine `supr_of_empty`, `supr_of_empty'`, and `supr_empty` into `supr_of_empty`, same for `infi`;
* replace `csupr_neg` with `csupr_of_empty` and `csupr_false`;
* adjust some proofs to use `casesI is_empty_of_nonempty α` instead of `by_cases h : nonempty α`.
@bors
Copy link

bors bot commented Aug 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(order/complete_lattice): use is_empty [Merged by Bors] - refactor(order/complete_lattice): use is_empty Aug 21, 2021
@bors bors bot closed this Aug 21, 2021
@bors bors bot deleted the supr-of-empty branch August 21, 2021 21:43
@eric-wieser
Copy link
Member

Thanks for this, I lost steam on #7826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @eric-wieser @jcommelin