Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/finite_dimensional): generalisations to division_ring #8822

Closed
wants to merge 6 commits into from

Conversation

semorrison
Copy link
Collaborator

I generalise a few results about finite dimensional modules from fields to division rings. Mostly this is me trying out @alexjbest's generalisation_linter. (review: it works really well, and is very helpful for finding the right home for lemmas, but it is slow).


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Aug 23, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 25, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 26, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 26, 2021
@jcommelin
Copy link
Member

CI is unhappy.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 6, 2021
bors bot pushed a commit that referenced this pull request Sep 6, 2021
…ring (#8822)

I generalise a few results about finite dimensional modules from fields to division rings. Mostly this is me trying out @alexjbest's `generalisation_linter`. (review: it works really well, and is very helpful for finding the right home for lemmas, but it is slow).
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 6, 2021
…ring (#8822)

I generalise a few results about finite dimensional modules from fields to division rings. Mostly this is me trying out @alexjbest's `generalisation_linter`. (review: it works really well, and is very helpful for finding the right home for lemmas, but it is slow).
@bors
Copy link

bors bot commented Sep 6, 2021

Build failed (retrying...):

@fpvandoorn
Copy link
Member

bors r-
please merge master and fix any errors

@bors
Copy link

bors bot commented Sep 7, 2021

Canceled.

@fpvandoorn
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Sep 7, 2021
…ring (#8822)

I generalise a few results about finite dimensional modules from fields to division rings. Mostly this is me trying out @alexjbest's `generalisation_linter`. (review: it works really well, and is very helpful for finding the right home for lemmas, but it is slow).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimensional): generalisations to division_ring [Merged by Bors] - feat(linear_algebra/finite_dimensional): generalisations to division_ring Sep 7, 2021
@bors bors bot closed this Sep 7, 2021
@bors bors bot deleted the finrank_division_ring branch September 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants