Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/finite_dimension): nontriviality lemmas #8851

Closed
wants to merge 1 commit into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Aug 24, 2021

A vector space of finrank greater than zero is nontrivial, likewise a vector space whose finrank is equal to the successor of a natural number.

Also write the non-fact version of finite_dimensional_of_finrank_eq_succ, a lemma which previously existed under a fact hypothesis, and rename the fact version to fact_finite_dimensional_of_finrank_eq_succ.


Open in Gitpod

@hrmacbeth hrmacbeth added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Aug 24, 2021
@semorrison
Copy link
Collaborator

Looks good. Could you just edit to PR description to say "greater than zero" rather than "greater than one"?

bors d+

@bors
Copy link

bors bot commented Aug 25, 2021

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Aug 25, 2021
@hrmacbeth
Copy link
Member Author

Oops, thanks!

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 25, 2021
bors bot pushed a commit that referenced this pull request Aug 25, 2021
A vector space of `finrank` greater than zero is `nontrivial`, likewise a vector space whose `finrank` is equal to the successor of a natural number.

Also write the non-`fact` version of `finite_dimensional_of_finrank_eq_succ`, a lemma which previously existed under a `fact` hypothesis, and rename the `fact` version to `fact_finite_dimensional_of_finrank_eq_succ`.
@bors
Copy link

bors bot commented Aug 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimension): nontriviality lemmas [Merged by Bors] - feat(linear_algebra/finite_dimension): nontriviality lemmas Aug 25, 2021
@bors bors bot closed this Aug 25, 2021
@bors bors bot deleted the finrank_nontrivial branch August 25, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants