Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(*): move code about ulift/plift #8863

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 25, 2021

  • move old file about ulift/plift from data.ulift to control.ulift;
  • redefine ulift.map etc without pattern matching;
  • create new data.ulift, move ulift.subsingleton etc from data.equiv.basic to this file;
  • add ulift.is_empty and plift.is_empty;
  • add ulift.exists, plift.exists, ulift.forall, and plift.forall;
  • rename equiv.nonempty_iff_nonempty to equiv.nonempty_congr to match equiv.subsingleton_congr etc;
  • rename plift.fintype to plift.fintype_Prop, add a new plift.fintype.

Open in Gitpod

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 26, 2021
bors bot pushed a commit that referenced this pull request Aug 26, 2021
* move old file about `ulift`/`plift` from `data.ulift` to `control.ulift`;
* redefine `ulift.map` etc without pattern matching;
* create new `data.ulift`, move `ulift.subsingleton` etc from `data.equiv.basic` to this file;
* add `ulift.is_empty` and `plift.is_empty`;
* add `ulift.exists`, `plift.exists`, `ulift.forall`, and `plift.forall`;
* rename `equiv.nonempty_iff_nonempty` to `equiv.nonempty_congr` to match `equiv.subsingleton_congr` etc;
* rename `plift.fintype` to `plift.fintype_Prop`, add a new `plift.fintype`.
@bors
Copy link

bors bot commented Aug 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(*): move code about ulift/plift [Merged by Bors] - refactor(*): move code about ulift/plift Aug 26, 2021
@bors bors bot closed this Aug 26, 2021
@bors bors bot deleted the ulift-move branch August 26, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants