Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(*): replace abs with vertical bar notation #8891

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - refactor(*): replace abs with vertical bar notation #8891

wants to merge 10 commits into from

Conversation

mans0954
Copy link
Collaborator

@mans0954 mans0954 commented Aug 27, 2021 •
edited

The notion of an "absolute value" occurs both in algebra (e.g. lattice ordered groups) and analysis (e.g. GM and GL-spaces). I introduced a has_abs notation class in #9172, along with the conventional mathematical vertical bar notation |.| for abs.

The notation vertical bar notation was already in use in some files as a local notation. This PR replaces abs with the vertical bar notation throughout mathlib.

Open in Gitpod

@mans0954 mans0954 mentioned this pull request Aug 27, 2021
Closed
@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Aug 27, 2021
Vierkantor
Vierkantor reviewed Aug 27, 2021
View reviewed changes
src/abs.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Aug 27, 2021
View reviewed changes
src/abs.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 27, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 28, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 28, 2021
bryangingechen
bryangingechen reviewed Aug 30, 2021
View reviewed changes
src/abs.lean Outdated Show resolved Hide resolved
@mans0954 mans0954 force-pushed the absolute-value branch 2 times, most recently from bdc242b to 01c403e Compare September 5, 2021 15:13
@mans0954 mans0954 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 5, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 6, 2021
@mans0954 mans0954 mentioned this pull request Sep 12, 2021
Closed
@mans0954 mans0954 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 13, 2021
@mans0954 mans0954 force-pushed the absolute-value branch 3 times, most recently from 56d1e81 to 4a69021 Compare September 16, 2021 20:11
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 16, 2021
@mans0954 mans0954 force-pushed the absolute-value branch 2 times, most recently from 673b796 to 4850439 Compare September 16, 2021 20:19
@mans0954 mans0954 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 17, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 19, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Sep 19, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@bryangingechen
Copy link
Collaborator

After you resolve the merge conflict, can you update the PR title / description to make it more clear how this differs from / builds on #9172? Thanks!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 30, 2021
@mans0954 mans0954 changed the title refactor(abs): add has_abs class refactor(*): replace abs with vertical bar notation Sep 30, 2021
@mans0954 mans0954 changed the title refactor(*): replace abs with vertical bar notation refactor(*): replace abs with vertical bar notation Sep 30, 2021
@mans0954 mans0954 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Sep 30, 2021
@semorrison
Copy link
Collaborator

Okay, if you could just fix the minor issue above, all else looks great. Thanks for this.

bors d+

@bors
Copy link

bors bot commented Sep 30, 2021

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 30, 2021
@mans0954
Copy link
Collaborator Author

mans0954 commented Oct 1, 2021

bors r+

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 1, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Oct 1, 2021

bors r-
Can you merge master and fix the conflict?

@bors
Copy link

bors bot commented Oct 1, 2021

Canceled.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 1, 2021
@mans0954
Copy link
Collaborator Author

mans0954 commented Oct 1, 2021

bors r+

@bors
Copy link

bors bot commented Oct 1, 2021

Canceled.

@mans0954
Copy link
Collaborator Author

mans0954 commented Oct 1, 2021

bors r-

@mans0954
Copy link
Collaborator Author

mans0954 commented Oct 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 1, 2021
@mans0954
refactor(*): replace abs with vertical bar notation (#8891)
d6bf2dd 
The notion of an "absolute value" occurs both in algebra (e.g. lattice ordered groups) and analysis (e.g. GM and GL-spaces). I introduced a `has_abs` notation class in #9172, along with the  conventional mathematical vertical bar notation `|.|` for `abs`.

The notation vertical bar notation was already in use in some files as a local notation. This PR replaces `abs` with the vertical bar notation throughout mathlib.
@bors
Copy link

bors bot commented Oct 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(*): replace abs with vertical bar notation [Merged by Bors] - refactor(*): replace abs with vertical bar notation Oct 1, 2021
@bors bors bot closed this Oct 1, 2021
@bors bors bot deleted the absolute-value branch October 1, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@semorrison semorrison semorrison left review comments

@Vierkantor Vierkantor Vierkantor left review comments

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mans0954 @semorrison @bryangingechen @sgouezel @eric-wieser @Vierkantor @jcommelin @ericrbg