Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finset): define finset.pimage #8907

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(data/finset): define finset.pimage #8907

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 29, 2021

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Aug 29, 2021
eric-wieser
eric-wieser reviewed Aug 31, 2021
View reviewed changes
src/logic/basic.lean Outdated Show resolved Hide resolved
ericrbg
ericrbg approved these changes Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from docs seems fine!

src/data/finset/pimage.lean Outdated Show resolved Hide resolved
src/data/finset/pimage.lean Show resolved Hide resolved
@ericrbg ericrbg added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 6, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 7, 2021
jcommelin
jcommelin approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 8, 2021
bors bot pushed a commit that referenced this pull request Sep 8, 2021
@urkud
feat(data/finset): define finset.pimage (#8907)
ec51460
@bors
Copy link

bors bot commented Sep 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finset): define finset.pimage [Merged by Bors] - feat(data/finset): define finset.pimage Sep 8, 2021
@bors bors bot closed this Sep 8, 2021
@bors bors bot deleted the finset-pimage branch September 8, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

@ericrbg ericrbg ericrbg approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @eric-wieser @jcommelin @ericrbg