[Merged by Bors] - fix(group_theory/group_action/defs): deduplicate const_smul_hom and distrib_mul_action.to_add_monoid_hom
#8953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `distrib_mul_action.to_add_monoid_hom` This removes `const_smul_hom` as `distrib_mul_action.to_add_monoid_hom` fits a larger family of similarly-named definitions. This also renames `distrib_mul_action.to_add_monoid_hom` to `distrib_mul_action.to_add_monoid_End` to better match its statement.
2 tasks
eric-wieser
force-pushed
the
eric-wieser/remove-const_smul_hom
branch
from
4e7eb0e
to
312b3f1
Compare
eric-wieser
added
the
awaiting-review
|
CI failure is bogus, and not worth rerunning the linter and tests for IMO. |
|
LGTM bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
… `distrib_mul_action.to_add_monoid_hom` (#8953) This removes `const_smul_hom` as `distrib_mul_action.to_add_monoid_hom` fits a larger family of similarly-named definitions. This also renames `distrib_mul_action.hom_add_monoid_hom` to `distrib_mul_action.to_add_monoid_End` to better match its statement. [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Definition.20elimination.20contest/near/237347199)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
const_smul_hom and distrib_mul_action.to_add_monoid_homconst_smul_hom and distrib_mul_action.to_add_monoid_hom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
const_smul_homasdistrib_mul_action.to_add_monoid_homfits a larger family of similarly-named definitions.This also renames
distrib_mul_action.hom_add_monoid_homtodistrib_mul_action.to_add_monoid_Endto better match its statement.Zulip thread