-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/complex/basic): convex_on.sup #8958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you're there, maybe be cautious and add the TODO explaining how to relax the typeclasses (if you have already figured it out?).
Have we defined has_Inf (α → β)
when has_Inf β
? If so, you might as well prove convex_on.Sup
and convex_on.Inf
, even though I think has_Inf γ
along with the current assumption ordered_module ℝ γ
imply subsingleton γ
.
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
With the generalization PR in master, I can place it in the right generalization level now. |
LGTM bors d=@YaelDillies |
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
LGTM bors d=@YaelDillies |
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
This looks all good! I'll PR |
Pull request successfully merged into master. Build succeeded: |
concave_on.le_on_segment
to monoids #8959