Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/complex/basic): convex_on.sup #8958

Closed
wants to merge 5 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Sep 1, 2021

@pechersky pechersky added the awaiting-review The author would like community review of the PR label Sep 1, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 1, 2021
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you're there, maybe be cautious and add the TODO explaining how to relax the typeclasses (if you have already figured it out?).

Have we defined has_Inf (α → β) when has_Inf β? If so, you might as well prove convex_on.Sup and convex_on.Inf, even though I think has_Inf γ along with the current assumption ordered_module ℝ γ imply subsingleton γ.

src/analysis/convex/basic.lean Outdated Show resolved Hide resolved
src/analysis/convex/basic.lean Outdated Show resolved Hide resolved
src/analysis/convex/basic.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@pechersky
Copy link
Collaborator Author

As long as you're there, maybe be cautious and add the TODO explaining how to relax the typeclasses (if you have already figured it out?).

Have we defined has_Inf (α → β) when has_Inf β? If so, you might as well prove convex_on.Sup and convex_on.Inf, even though I think has_Inf γ along with the current assumption ordered_module ℝ γ imply subsingleton γ.

With the generalization PR in master, I can place it in the right generalization level now.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 2, 2021
@eric-wieser
Copy link
Member

LGTM

bors d=@YaelDillies

@bors
Copy link

bors bot commented Sep 3, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Member

LGTM

bors d=@YaelDillies

@bors
Copy link

bors bot commented Sep 3, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 3, 2021
@YaelDillies
Copy link
Collaborator

This looks all good! I'll PR convex_on.Sup and convex_on.Inf myself.
bors merge

bors bot pushed a commit that referenced this pull request Sep 3, 2021
@bors
Copy link

bors bot commented Sep 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/complex/basic): convex_on.sup [Merged by Bors] - feat(analysis/complex/basic): convex_on.sup Sep 3, 2021
@bors bors bot closed this Sep 3, 2021
@bors bors bot deleted the pechersky/convex-on-sup branch September 3, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants