Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/operator_norm): variants of continuous_linear_map.lsmul and their properties #8984

Closed
wants to merge 9 commits into from

Conversation

RemyDegenne
Copy link
Collaborator


Open in Gitpod

@hrmacbeth
Copy link
Member

Sorry for not pointing you in this direction earlier, but I wonder if lsmul_left is the same as continuous_linear_map.to_span_singleton?

Also, I wrote continuous_linear_map.to_span_singleton when I was new to Lean and didn't know the library. Probably lsmul_left is a better name. Also I would not be at all surprised if the construction exists in another place under some third name. And certainly it's currently in the wrong place, it should live in topology.algebra.module rather than analysis.operator_norm with a definition like

def continuous_linear_map.to_span_singleton (a : E)  : 𝕜 →L[𝕜] E :=
{ cont := continuous_smul.comp (continuous_id.prod_mk continuous_const),
  .. linear_map.to_span_singleton 𝕜 E a }

Anyway, feel free to fix any of this, but also feel free to just convert the lsmul_left part of your PR into lemmas about continuous_linear_map.to_span_singleton and leave the rest of the mess for someone (me?) later.

@hrmacbeth
Copy link
Member

hrmacbeth commented Sep 5, 2021

Also (again sorry for not noticing this earlier) another way of representing lsmul_right E r is as r • (continuous_linear_map.id 𝕜 E). Is it perhaps better to just use the latter rather than making the former as a formal definition?

I checked: replacing lsmul_right F (μ s).to_real by (μ s).to_real • (continuous_linear_map.id 𝕜 F) in your other PR works out (without developing a lsmul_right theory). Most proofs become by simp [weighted_smul]. The lemma norm_weighted_smul_le needs a bit of reworking to pass through norm_id_le (or maybe it'd be worth salvaging your lemma

lemma norm_lsmul_right_le (r : 𝕜) : ∥lsmul_right E r∥ ≤ ∥r∥ :=
op_norm_le_bound _ (norm_nonneg _) (λ x, by rw [lsmul_right_apply, norm_smul])

in the adapted form

lemma norm_smul_id_le (r : 𝕜) : ∥r • (continuous_linear_map.id 𝕜 E)∥ ≤ ∥r∥ :=
by simpa using mul_le_mul_of_nonneg_left norm_id_le (norm_nonneg r)

@RemyDegenne
Copy link
Collaborator Author

I remove lsmul_right and renamed the lemmas about lsmul_left to apply to to_span_singleton. One lemma is placed near lsmul and not near to_smul_singleton because apparently some normed_space instance is not yet defined near to_span_singleton.

@hrmacbeth
Copy link
Member

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 6, 2021
bors bot pushed a commit that referenced this pull request Sep 6, 2021
@bors
Copy link

bors bot commented Sep 7, 2021

Build failed (retrying...):

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 7, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Sep 7, 2021

Can you merge master and fix the conflict?

@bors
Copy link

bors bot commented Sep 7, 2021

Canceled.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 7, 2021
@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Sep 8, 2021
@RemyDegenne
Copy link
Collaborator Author

I merged master and fixed the conflict.

@hrmacbeth
Copy link
Member

Thanks!

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 8, 2021
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Sep 8, 2021
bors bot pushed a commit that referenced this pull request Sep 8, 2021
…ear_map.lsmul and their properties (#8984)




Co-authored-by: RemyDegenne <remydegenne@gmail.com>
@bors
Copy link

bors bot commented Sep 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/operator_norm): variants of continuous_linear_map.lsmul and their properties [Merged by Bors] - feat(analysis/normed_space/operator_norm): variants of continuous_linear_map.lsmul and their properties Sep 8, 2021
@bors bors bot closed this Sep 8, 2021
@bors bors bot deleted the lsmul_api branch September 8, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants