-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/real/sqrt): nnreal.coe_sqrt
and nnreal.sqrt_eq_rpow
#9025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
The author would like community review of the PR
label
Sep 6, 2021
jcommelin
reviewed
Sep 6, 2021
Closed
sgouezel
reviewed
Sep 7, 2021
semorrison
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 7, 2021
YaelDillies
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Sep 8, 2021
jcommelin
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 9, 2021
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
) Also rename a few lemmas: * `nnreal.mul_sqrt_self` -> `nnreal.mul_self_sqrt` to follow `real.mul_self_sqrt` * `real.sqrt_le` -> `real.sqrt_le_sqrt_iff` * `real.sqrt_lt` -> `real.sqrt_lt_sqrt_iff` and provide a few more for commodity: * `nnreal.sqrt_sq` * `nnreal.sq_sqrt` * `real.sqrt_lt_sqrt` * `real.sqrt_lt_sqrt_iff_of_pos` * `nnreal.sqrt_le_sqrt_iff` * `nnreal.sqrt_lt_sqrt_iff` Closes #8016
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/real/sqrt):
[Merged by Bors] - feat(data/real/sqrt): Sep 9, 2021
nnreal.coe_sqrt
and nnreal.sqrt_eq_rpow
nnreal.coe_sqrt
and nnreal.sqrt_eq_rpow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename a few lemmas:
nnreal.mul_sqrt_self
->nnreal.mul_self_sqrt
to followreal.mul_self_sqrt
real.sqrt_le
->real.sqrt_le_sqrt_iff
real.sqrt_lt
->real.sqrt_lt_sqrt_iff
and provide a few more for commodity:
nnreal.sqrt_sq
nnreal.sq_sqrt
real.sqrt_lt_sqrt
real.sqrt_lt_sqrt_iff_of_pos
nnreal.sqrt_le_sqrt_iff
nnreal.sqrt_lt_sqrt_iff
Closes #8016