Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/real/sqrt): nnreal.coe_sqrt and nnreal.sqrt_eq_rpow #9025

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 6, 2021

Also rename a few lemmas:

  • nnreal.mul_sqrt_self -> nnreal.mul_self_sqrt to follow real.mul_self_sqrt
  • real.sqrt_le -> real.sqrt_le_sqrt_iff
  • real.sqrt_lt -> real.sqrt_lt_sqrt_iff

and provide a few more for commodity:

  • nnreal.sqrt_sq
  • nnreal.sq_sqrt
  • real.sqrt_lt_sqrt
  • real.sqrt_lt_sqrt_iff_of_pos
  • nnreal.sqrt_le_sqrt_iff
  • nnreal.sqrt_lt_sqrt_iff

Closes #8016


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Sep 6, 2021
src/data/real/sqrt.lean Show resolved Hide resolved
src/data/real/sqrt.lean Outdated Show resolved Hide resolved
src/data/real/sqrt.lean Outdated Show resolved Hide resolved
Co-authored-by: Johan Commelin <johan@commelin.net>
@YaelDillies YaelDillies linked an issue Sep 7, 2021 that may be closed by this pull request
src/data/real/sqrt.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 7, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 8, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 9, 2021
bors bot pushed a commit that referenced this pull request Sep 9, 2021
)

Also rename a few lemmas:
* `nnreal.mul_sqrt_self` -> `nnreal.mul_self_sqrt` to follow `real.mul_self_sqrt`
* `real.sqrt_le` -> `real.sqrt_le_sqrt_iff`
* `real.sqrt_lt` -> `real.sqrt_lt_sqrt_iff`

and provide a few more for commodity:
* `nnreal.sqrt_sq`
* `nnreal.sq_sqrt`
* `real.sqrt_lt_sqrt`
* `real.sqrt_lt_sqrt_iff_of_pos`
* `nnreal.sqrt_le_sqrt_iff`
* `nnreal.sqrt_lt_sqrt_iff`

Closes #8016
@bors
Copy link

bors bot commented Sep 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/sqrt): nnreal.coe_sqrt and nnreal.sqrt_eq_rpow [Merged by Bors] - feat(data/real/sqrt): nnreal.coe_sqrt and nnreal.sqrt_eq_rpow Sep 9, 2021
@bors bors bot closed this Sep 9, 2021
@bors bors bot deleted the coe_sqrt branch September 9, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqrt_le vs log_le_log
4 participants