Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/module/ordered): simple smul lemmas #9077

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

These are the negative versions of the lemmas in ordered_smul, which suggests that both files should be merged.
Note however that, contrary to those, they need module k M instead of merely smul_with_zero k M.


So, Yakov, you said only a few lemmas required ordered_module? 馃榾
Open in Gitpod

@YaelDillies YaelDillies added medium awaiting-review The author would like community review of the PR labels Sep 8, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃帀

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 8, 2021
bors bot pushed a commit that referenced this pull request Sep 8, 2021
These are the negative versions of the lemmas in `ordered_smul`, which suggests that both files should be merged.
Note however that, contrary to those, they need `module k M` instead of merely `smul_with_zero k M`.
@bors
Copy link

bors bot commented Sep 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/module/ordered): simple smul lemmas [Merged by Bors] - feat(algebra/module/ordered): simple smul lemmas Sep 8, 2021
@bors bors bot closed this Sep 8, 2021
@bors bors bot deleted the yael/smul branch September 8, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants