New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivial
#9090
Conversation
ericrbg
commented
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
Since you are modifying the file |
I did that and then got a little carried away — sorry! |
nontrivial
requirementsnontrivial
s
nontrivial
snontrivial
Looks good to me. (An aside: the description of the bors merge |
Sorry Scott, forgot to remove it after the second commit! The first one was like 7 lines :) |
Pull request successfully merged into master. Build succeeded: |
nontrivial
nontrivial
Sorry to bother you again, but I think you changed the name of too many lemmas: |
#9116, sorry I messed it up! I went through and all the other namespaces seemed okay |