Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivial #9090

Closed
wants to merge 2 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Sep 8, 2021


Open in Gitpod

@ericrbg ericrbg added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Sep 8, 2021
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@riccardobrasca
Copy link
Member

Since you are modifying the file ring_theory.polynomial.cyclotomic.lean can you check the name of the last lemmas? There is at least cyclotomic.irreducible that should definitely be polynomial.cyclotomic.irreducible (I think I closed the namespace and then forget about it).

@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 8, 2021

I did that and then got a little carried away ­— sorry!

@ericrbg ericrbg changed the title chore(ring_theory/polynomial/cyclotomic): remove some nontrivial requirements chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivials Sep 9, 2021
@ericrbg ericrbg changed the title chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivials chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivial Sep 9, 2021
@semorrison
Copy link
Collaborator

Looks good to me. (An aside: the description of the easy tag is "<20 of review time". I agree this one is easy, but not short enough to really be easy.)

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 9, 2021
@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 9, 2021

Sorry Scott, forgot to remove it after the second commit! The first one was like 7 lines :)

@bors
Copy link

bors bot commented Sep 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivial [Merged by Bors] - chore(ring_theory/polynomial/cyclotomic): golf+remove nontrivial Sep 9, 2021
@bors bors bot closed this Sep 9, 2021
@bors bors bot deleted the cyclotomic_nontrivial branch September 9, 2021 09:36
@riccardobrasca
Copy link
Member

Sorry to bother you again, but I think you changed the name of too many lemmas: polynomial.cyclotomic.irreducible and polynomial.cyclotomic_eq_minpoly are perfect now, but minpoly_primitive_root_dvd_cyclotomic I think it should not have polynomial.. I am not sure about the other ones...

@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 9, 2021

#9116, sorry I messed it up! I went through and all the other namespaces seemed okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants