Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/affine_space/affine_subspace): prove that a set whose affine span is top cannot be empty. #9113

Closed
wants to merge 3 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Sep 9, 2021

The lemma finset.card_sdiff_add_card is unrelated but I've been meaning to add it
and now seemed like a good time since I'm touching data/finset/basic.lean anyway.


Open in Gitpod

…hose affine span is top cannot be empty.

The lemma `finset.card_sdiff_add_card` is unrelated but I've been meaning to add it
and now seemed like a good time since I'm touching `data/finset/basic.lean` anyway.
@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Sep 9, 2021
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/data/set/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 11, 2021

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a few minor remarks. I see that you're not going to merge it in the next few days, so please merge master and wait for CI before adding it to the queue.

bors d+

src/data/finset/basic.lean Outdated Show resolved Hide resolved
src/linear_algebra/affine_space/affine_subspace.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 11, 2021
@ocfnash
Copy link
Collaborator Author

ocfnash commented Sep 22, 2021

bors merge

bors bot pushed a commit that referenced this pull request Sep 22, 2021
…hose affine span is top cannot be empty. (#9113)



The lemma `finset.card_sdiff_add_card` is unrelated but I've been meaning to add it
and now seemed like a good time since I'm touching `data/finset/basic.lean` anyway.
@bors
Copy link

bors bot commented Sep 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/affine_space/affine_subspace): prove that a set whose affine span is top cannot be empty. [Merged by Bors] - feat(linear_algebra/affine_space/affine_subspace): prove that a set whose affine span is top cannot be empty. Sep 22, 2021
@bors bors bot closed this Sep 22, 2021
@ocfnash ocfnash deleted the affine_subspace_lemmas branch October 3, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants