Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ordered_monoid): order_embedding.mul_left #9127

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/ordered_monoid): order_embedding.mul_left #9127

wants to merge 2 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

eric-wieser
eric-wieser approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment to order_iso.mul_left and order_iso.mul_right referencing these new definitions?

bors d+

src/algebra/ordered_monoid.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 10, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Sep 10, 2021
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 11, 2021
bors bot pushed a commit that referenced this pull request Sep 11, 2021
@semorrison
feat(algebra/ordered_monoid): order_embedding.mul_left (#9127)
2e9f708
@bors
Copy link

bors bot commented Sep 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_monoid): order_embedding.mul_left [Merged by Bors] - feat(algebra/ordered_monoid): order_embedding.mul_left Sep 11, 2021
@bors bors bot closed this Sep 11, 2021
@bors bors bot deleted the order_embedding.mul_left branch September 11, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @eric-wieser