Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(linear_algebra/basic): generalize add_monoid_hom_lequiv_{nat,int} #9233

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@riccardobrasca
Copy link
Member

LGTM

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 16, 2021
@riccardobrasca
Copy link
Member

Maybe it is reasonable to add some compatibility when we have R S M [algebra R S] [module R M] [module S M] [is_scalar_tower R S M] ...

@eric-wieser
Copy link
Member Author

I'm not sure I understand what you mean by your second comment - the choice of R is entirely free, there is no need to add any extra variables.

@riccardobrasca
Copy link
Member

riccardobrasca commented Sep 17, 2021

I mean the following

example {A B : Type*} (R : Type*) (S : Type*) [comm_semiring R] [semiring S] [algebra R S]
  [add_comm_group A] [add_comm_group B] [module R B] [module S B] [is_scalar_tower R S B] :
  linear_equiv.restrict_scalars R (add_monoid_hom_lequiv_int S) =
  (add_monoid_hom_lequiv_int R : (A →+ B) ≃ₗ[R] (A →ₗ[ℤ] B)) := rfl

@eric-wieser
Copy link
Member Author

While harmless, I don't think that's really worth it; there are probably 10s of defs missing .restrict_scalars lemmas like that.

Having said that, if you find yourself needing that type of lemma I'm happy to approve a PR adding them (but note your assumptions are too strong there, linear_equiv.restrict_scalars does not require an algebra)

@urkud
Copy link
Member

urkud commented Sep 22, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 22, 2021
bors bot pushed a commit that referenced this pull request Sep 22, 2021
@bors
Copy link

bors bot commented Sep 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/basic): generalize add_monoid_hom_lequiv_{nat,int} [Merged by Bors] - chore(linear_algebra/basic): generalize add_monoid_hom_lequiv_{nat,int} Sep 22, 2021
@bors bors bot closed this Sep 22, 2021
@bors bors bot deleted the eric-wieser/add_monoid_hom_lequiv_int branch September 22, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants