[Merged by Bors] - feat(order/filter,*): lemmas about filter.ne_bot
#9234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Sep 17, 2021
sgouezel
reviewed
Sep 17, 2021
| { simp [comap_ne_bot_iff_frequently, h] } | ||
| end | ||
|
|
||
| @[instance] lemma comap_fst_ne_bot [nonempty β] {f : filter α} [ne_bot f] : |
There was a problem hiding this comment.
Is there a reason why you are using @[instance] lemma instead of just instance, here and in most lemmas below? (but not in Coprod_ne_bot, surprisingly).
There was a problem hiding this comment.
With @[instance] lemma, the lemma is not protected. For Coprod_ne_bot this is a typo.
sgouezel
added
awaiting-author
urkud
added
awaiting-review
|
bors d+ |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 18, 2021
* add `prod.range_fst`, `prod.range_snd`, `set.range_eval`; * add `function.surjective_eval`; * add `filter.*_ne_bot` and/or `filter.*_ne_bot_iff` lemmas for `sup`, `supr`, `comap prod.fst _`, `comap prod.snd _`, `coprod`, `Coprod`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
filter.ne_botfilter.ne_bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prod.range_fst,prod.range_snd,set.range_eval;function.surjective_eval;filter.*_ne_botand/orfilter.*_ne_bot_ifflemmas forsup,supr,comap prod.fst _,comap prod.snd _,coprod,Coprod.