Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/compact_open): convergence in the compact-open topology can be checked on compact sets #9240

Closed
wants to merge 4 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Sep 17, 2021

@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Sep 17, 2021
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 17, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

Comment on lines +150 to +153
lemma exists_tendsto_compact_open_iff_forall [locally_compact_space α] [t2_space α] [t2_space β]
{ι : Type*} {l : filter ι} [filter.ne_bot l] (F : ι → C(α, β)) :
(∃ f, filter.tendsto F l (𝓝 f))
↔ ∀ (s : set α) (hs : is_compact s), ∃ f, filter.tendsto (λ i, (F i).restrict s) l (𝓝 f) :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to the end-user if there were companion lemmas that say "those fs for each s are the restriction of f to each s" and in the other direction "and all these fs can be glued together, obtaining a function to which F converges"?

No problem if you think either "it wouldn't be that useful" or "it can happen later"!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of more general lemmas which imply this information: (1) if a family F converges to f, then the restrictions of F to s converge to the restriction of f to s; (2) under appropriate hypotheses continuous_map is a Hausdorff space (hence, limits are unique). I think these are useful so thanks for prompting this!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to have the explicit lemmas in both directions, to be sure we really have the API available, but I can see the argument that the explicit lemmas might not often be needed. I'll hit bors d+ now, but do feel free to add more if you like! :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! My instinct is the opposite, that the gluing construction lift_cover_restrict' is an implementation detail for which it's better to expose only certain carefully selected properties :-). I'll take your bors d+ for now, but I expect that when @CBirkbeck and others start using this construction heavily, we'll find out what's best.

@semorrison
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Sep 23, 2021

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 23, 2021
@hrmacbeth
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 23, 2021
bors bot pushed a commit that referenced this pull request Sep 24, 2021
@bors
Copy link

bors bot commented Sep 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/compact_open): convergence in the compact-open topology can be checked on compact sets [Merged by Bors] - feat(topology/compact_open): convergence in the compact-open topology can be checked on compact sets Sep 24, 2021
@bors bors bot closed this Sep 24, 2021
@bors bors bot deleted the glue-compact-open branch September 24, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants