Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/polynomial/algebra_map): aeval_tower #9250

Closed
wants to merge 34 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Sep 17, 2021


aeval_tower is for defining alg_homs out of polynomial R over a smaller base ring than R. I also added an extra extensionality lemma for alg homs. It comes above the current alg_hom_ext so it has lower priority.

Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Sep 17, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 17, 2021
@ChrisHughes24 ChrisHughes24 changed the title feat(data/polynomial/algebra_map): aeval₂ feat(data/polynomial/algebra_map): aeval_tower Sep 17, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

src/algebra/algebra/tower.lean Outdated Show resolved Hide resolved
src/data/polynomial/algebra_map.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 27, 2021

✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 27, 2021
Co-authored-by: Johan Commelin <johan@commelin.net>
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 27, 2021
Co-authored-by: Johan Commelin <johan@commelin.net>
@ChrisHughes24
Copy link
Member Author

bors merge

@bors
Copy link

bors bot commented Sep 27, 2021

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 27, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 27, 2021
@ChrisHughes24
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2021
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 27, 2021

Build failed:

@ChrisHughes24
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2021
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial/algebra_map): aeval_tower [Merged by Bors] - feat(data/polynomial/algebra_map): aeval_tower Sep 27, 2021
@bors bors bot closed this Sep 27, 2021
@bors bors bot deleted the aeval2 branch September 27, 2021 22:35
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 10, 2023
…lynomials (#8116)

This adds an `AlgHom` version of `eval₂RingHom'`, and a stronger ext lemma for noncommutative algebras.
This is a follow-up to leanprover-community/mathlib#9250

This better ext lemma golfs away most of a nasty proof.
grunweg pushed a commit to leanprover-community/mathlib4 that referenced this pull request Dec 15, 2023
…lynomials (#8116)

This adds an `AlgHom` version of `eval₂RingHom'`, and a stronger ext lemma for noncommutative algebras.
This is a follow-up to leanprover-community/mathlib#9250

This better ext lemma golfs away most of a nasty proof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants