[Merged by Bors] - feat(data/{list,multiset}): add can_lift instances
#9262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use them in `submonoid.{list,multiset}_prod_mem`.
2 tasks
eric-wieser
reviewed
Sep 20, 2021
| S.subtype.map_list_prod l | ||
|
|
||
| @[simp, norm_cast] theorem coe_multiset_prod {M} [comm_monoid M] (S : submonoid M) | ||
| @[simp, norm_cast, to_additive] theorem coe_multiset_prod {M} [comm_monoid M] (S : submonoid M) |
There was a problem hiding this comment.
Does this put norm_cast on the additivized version?
eric-wieser
approved these changes
Sep 20, 2021
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
* add `can_lift` instances for `set`, `list`, `multiset`, and `finset`;
* use them in `submonoid.{list,multiset}_prod_mem`;
* more `to_additive` attrs in `group_theory.submonoid.membership`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
can_lift instancescan_lift instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can_liftinstances forset,list,multiset, andfinset;submonoid.{list,multiset}_prod_mem;to_additiveattrs ingroup_theory.submonoid.membership.