Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(analysis/normed_space/conformal_linear_map): delay dependence on inner products #9293

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - chore(analysis/normed_space/conformal_linear_map): delay dependence on inner products #9293

wants to merge 8 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@semorrison @pechersky
Update src/analysis/calculus/conformal.lean
0917b5c 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 20, 2021
@hrmacbeth
Copy link
Member

I took the liberty of pushing two changes. One is just removing an import. The other is, if we're going to rename part of the calculus facts as analysis.calculus.conformal.inner_product, then shall we rename the rest from analysis.calculus.conformal to analysis.calculus.conformal.normed_space for consistency? Feel free to revert any of this.

@hrmacbeth
Copy link
Member

At some point I'd like to make a new second-tier folder analysis.inner_product_space, and split up the huge analysis.normed_space.inner_product file as a series of files in the new folder. At that point analysis.normed_space.conformal_linear_map.inner_product can move to analysis.inner_product_space.conformal_linear_map.

@hrmacbeth
Copy link
Member

I approve your changes, btw, so if you approve mine, let's merge!

bors d+

@bors
Copy link

bors bot commented Sep 23, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 23, 2021
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 23, 2021
bors bot pushed a commit that referenced this pull request Sep 23, 2021
@semorrison @hrmacbeth
chore(analysis/normed_space/conformal_linear_map): delay dependence o…
54eb603 
…n inner products (#9293)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/normed_space/conformal_linear_map): delay dependence on inner products [Merged by Bors] - chore(analysis/normed_space/conformal_linear_map): delay dependence on inner products Sep 23, 2021
@bors bors bot closed this Sep 23, 2021
@hrmacbeth hrmacbeth deleted the inner_product branch September 24, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pechersky pechersky pechersky left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @hrmacbeth @pechersky