Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/normed_space/basic): the rescaling of a ball is a ball #9297

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(analysis/normed_space/basic): the rescaling of a ball is a ball #9297

wants to merge 9 commits into from

Conversation

sgouezel
Copy link
Collaborator

@sgouezel sgouezel commented Sep 20, 2021 •
edited

Also rename all statements with ball_0 to ball_zero for coherence.

Open in Gitpod

@sgouezel sgouezel added the awaiting-review The author would like community review of the PR label Sep 20, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 20, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 20, 2021
eric-wieser
eric-wieser approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Feel free to ignore the iff comment

src/topology/metric_space/basic.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 21, 2021

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Sep 21, 2021
@sgouezel
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 21, 2021
bors bot pushed a commit that referenced this pull request Sep 21, 2021
@sgouezel
feat(analysis/normed_space/basic): the rescaling of a ball is a ball (#…
e0d568e 
…9297)

Also rename all statements with `ball_0` to `ball_zero` for coherence.
@bors
Copy link

bors bot commented Sep 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/basic): the rescaling of a ball is a ball [Merged by Bors] - feat(analysis/normed_space/basic): the rescaling of a ball is a ball Sep 21, 2021
@bors bors bot closed this Sep 21, 2021
@bors bors bot deleted the more_ball branch September 21, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgouezel @eric-wieser