Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/measure/measure_space_def): some simple lemmas about measures and intersection #9306

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(measure_theory/measure/measure_space_def): some simple lemmas about measures and intersection #9306

wants to merge 3 commits into from

Conversation

alexjbest
Copy link
Member

From #2819

Open in Gitpod

@alexjbest alexjbest added the awaiting-review The author would like community review of the PR label Sep 20, 2021
@urkud
Copy link
Member

urkud commented Sep 22, 2021

I had an impression that we're trying to assume ≠ ∞ and prove < ∞. @sgouezel ?

@alexjbest
Copy link
Member Author

That certainly makes sense from a usability point of view, seems to me having these variations for library_search is useful too? I don't really have a use for the ≠ ∞ ones myself, just seemed like a small gap to only have one side.

urkud
urkud reviewed Sep 23, 2021
View reviewed changes
src/measure_theory/measure/measure_space_def.lean Outdated
inter_comm t s ▸ measure_inter_lt_top_of_left ht_finite

lemma measure_inter_ne_top_of_left (hs_finite : μ s ≠ ∞) : μ (s ∩ t) ≠ ∞ :=
(measure_inter_lt_top_of_left (lt_top_iff_ne_top.mpr hs_finite)).ne
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this lemma becomes

Suggested change
(measure_inter_lt_top_of_left (lt_top_iff_ne_top.mpr hs_finite)).ne
(measure_inter_lt_top_of_left hs_finite).ne

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 23, 2021
@alexjbest
Copy link
Member Author

Ok, I just removed the other versions, to just stick to the rule of thumb.

@alexjbest alexjbest added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 23, 2021
@sgouezel sgouezel removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Sep 23, 2021
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 23, 2021
bors bot pushed a commit that referenced this pull request Sep 23, 2021
@alexjbest
feat(measure_theory/measure/measure_space_def): some simple lemmas ab…
14bcb2e 
…out measures and intersection (#9306)

From #2819
@bors
Copy link

bors bot commented Sep 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/measure/measure_space_def): some simple lemmas about measures and intersection [Merged by Bors] - feat(measure_theory/measure/measure_space_def): some simple lemmas about measures and intersection Sep 23, 2021
@bors bors bot closed this Sep 23, 2021
@bors bors bot deleted the alexjbest/measure-mono branch September 23, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexjbest @urkud @sgouezel