Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/complex/module): rename complex.smul_coe to real_smul #9326

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 21, 2021

  • the name was misleading b/c there is no coe in the LHS;
  • add complex.coe_smul: given x : ℝ and y : E, we have
    (x : ℂ) • y = x • y;
  • add normed_space.complex_to_real.

Open in Gitpod

* the name was misleading b/c there is no `coe` in the LHS;
* add `complex.coe_smul`: given `x : ℝ` and `y : E`, we have
  `(x : ℂ) • y = x • y`;
* add `normed_space.complex_to_real`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Sep 21, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 22, 2021
bors bot pushed a commit that referenced this pull request Sep 22, 2021
…9326)

* the name was misleading b/c there is no `coe` in the LHS;
* add `complex.coe_smul`: given `x : ℝ` and `y : E`, we have
  `(x : ℂ) • y = x • y`;
* add `normed_space.complex_to_real`.
@bors
Copy link

bors bot commented Sep 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/complex/module): rename complex.smul_coe to real_smul [Merged by Bors] - chore(data/complex/module): rename complex.smul_coe to real_smul Sep 22, 2021
@bors bors bot closed this Sep 22, 2021
@bors bors bot deleted the complex-module branch September 22, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants