Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/fin,*): redefine insert_nth, add lemmas #9349

Closed
wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 23, 2021

data/fin

  • add fin.succ_above_cast_lt, fin.succ_above_pred,
    fin.cast_lt_succ_above, fin.pred_succ_above;
  • add fin.exists_succ_above_eq and fin.exists_succ_above_eq_iff,
    use the latter to prove fin.range_succ_above;
  • add @[simp] to fin.succ_above_left_inj;
  • add fin.cases_succ_above induction principle, redefine
    fin.insert_nth to be fin.cases_succ_above;
  • add lemmas about fin.insert_nth and some algebraic operations.

data/fintype/basic

  • add finset.insert_compl_self;
  • add fin.image_succ_above_univ, fin.image_succ_univ,
    fin.image_cast_succ and use them to prove fin.univ_succ,
    fin.univ_cast_succ, and fin.univ_succ_above using by simp;

data/fintype/card

  • slightly golf the proof of fin.prod_univ_succ_above;
  • use @[to_additive] to generate some proofs.

topology/*

  • prove continuity of fin.insert_nth in both arguments and add all
    the standard dot-notation *.fin_insert_nth lemmas (* is one of
    filter.tendsto, continuous_at, continuous_within_at,
    continuous_on, continuous).

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Sep 23, 2021
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 26, 2021
bors bot pushed a commit that referenced this pull request Sep 26, 2021
### `data/fin`

* add `fin.succ_above_cast_lt`, `fin.succ_above_pred`,
  `fin.cast_lt_succ_above`, `fin.pred_succ_above`;
* add `fin.exists_succ_above_eq` and `fin.exists_succ_above_eq_iff`,
  use the latter to prove `fin.range_succ_above`;
* add `@[simp]` to `fin.succ_above_left_inj`;
* add `fin.cases_succ_above` induction principle, redefine
  `fin.insert_nth` to be `fin.cases_succ_above`;
* add lemmas about `fin.insert_nth` and some algebraic operations.

### `data/fintype/basic`

* add `finset.insert_compl_self`;
* add `fin.image_succ_above_univ`, `fin.image_succ_univ`,
  `fin.image_cast_succ` and use them to prove `fin.univ_succ`,
  `fin.univ_cast_succ`, and `fin.univ_succ_above` using `by simp`;

### `data/fintype/card`

* slightly golf the proof of `fin.prod_univ_succ_above`;
* use `@[to_additive]` to generate some proofs.

### `topology/*`

* prove continuity of `fin.insert_nth` in both arguments and add all
  the standard dot-notation `*.fin_insert_nth` lemmas (`*` is one of
  `filter.tendsto`, `continuous_at`, `continuous_within_at`,
  `continuous_on`, `continuous`).
@bors
Copy link

bors bot commented Sep 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/fin,*): redefine insert_nth, add lemmas [Merged by Bors] - refactor(data/fin,*): redefine insert_nth, add lemmas Sep 26, 2021
@bors bors bot closed this Sep 26, 2021
@bors bors bot deleted the fin-lemmas branch September 26, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants