Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/basic): rename monotonicity concepts #9383

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - chore(order/basic): rename monotonicity concepts #9383

wants to merge 12 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 25, 2021 •
edited by eric-wieser

This:

  • Renames various mono lemmas either to enable dot notation (in some cases for types that don't exist yet) or to reflect they indicate monotonicity within a particular domain.
  • Renames strict_mono.top_preimage_top' to strict_mono.maximal_preimage_top'
  • Sorts some imports
  • Replaces some rcases with obtain

Split off #9119

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Sep 25, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 26, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Sep 26, 2021
This was referenced Sep 27, 2021
Closed
Closed
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 27, 2021
@eric-wieser
Merge remote-tracking branch 'origin/staging' into rename_mono
fc18181 
# Conflicts:
#	src/algebra/lie/solvable.lean
#	src/analysis/calculus/mean_value.lean
#	src/analysis/special_functions/integrals.lean
#	src/analysis/special_functions/trigonometric/basic.lean
#	src/data/real/pi/wallis.lean
#	src/measure_theory/constructions/borel_space.lean
#	src/measure_theory/function/lp_space.lean
#	src/measure_theory/integral/integrable_on.lean
#	src/measure_theory/integral/interval_integral.lean
#	src/measure_theory/integral/set_integral.lean
#	src/order/bounded_lattice.lean
#	src/order/filter/at_top_bot.lean
#	src/order/filter/bases.lean
#	src/order/filter/extr.lean
#	src/order/filter/indicator_function.lean
#	src/topology/G_delta.lean
#	src/topology/algebra/ordered/basic.lean
#	src/topology/uniform_space/cauchy.lean
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 27, 2021
@eric-wieser eric-wieser mentioned this pull request Sep 27, 2021
Closed
@eric-wieser
Merge branch 'eric-wieser/monotone-docstrings' into rename_mono
8a4e434 
# Conflicts:
#	src/analysis/calculus/mean_value.lean
#	src/order/conditionally_complete_lattice.lean
#	src/order/lattice.lean
#	src/topology/algebra/ordered/basic.lean
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 28, 2021
@eric-wieser
Merge remote-tracking branch 'origin/master' into eric-wieser/monoton…
53d54a6 
…e-docstrings

# Conflicts:
#	src/topology/algebra/ordered/basic.lean
@eric-wieser
Merge branch 'eric-wieser/monotone-docstrings' into rename_mono
65ffc7a 
# Conflicts:
#	src/topology/algebra/ordered/basic.lean
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Sep 28, 2021
@eric-wieser
Merge remote-tracking branch 'origin/master' into rename_mono
a6e0531 
# Conflicts:
#	src/order/conditionally_complete_lattice.lean
#	src/order/lattice.lean
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 28, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 28, 2021
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 30, 2021
bors bot pushed a commit that referenced this pull request Sep 30, 2021
@YaelDillies @eric-wieser
chore(order/basic): rename monotonicity concepts (#9383)
1f51a7e 
This:
* Renames various mono lemmas either to enable dot notation (in some cases for types that don't exist yet) or to reflect they indicate monotonicity within a particular domain.
* Renames `strict_mono.top_preimage_top'` to `strict_mono.maximal_preimage_top'`
* Sorts some imports
* Replaces some `rcases` with `obtain`



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 30, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 30, 2021
@YaelDillies @eric-wieser
chore(order/basic): rename monotonicity concepts (#9383)
2fd713a 
This:
* Renames various mono lemmas either to enable dot notation (in some cases for types that don't exist yet) or to reflect they indicate monotonicity within a particular domain.
* Renames `strict_mono.top_preimage_top'` to `strict_mono.maximal_preimage_top'`
* Sorts some imports
* Replaces some `rcases` with `obtain`



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/basic): rename monotonicity concepts [Merged by Bors] - chore(order/basic): rename monotonicity concepts Sep 30, 2021
@bors bors bot closed this Sep 30, 2021
@bors bors bot deleted the rename_mono branch September 30, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @jcommelin @eric-wieser