Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/special_functions): real derivs of complex.exp and complex.log #9422

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(analysis/special_functions): real derivs of complex.exp and complex.log #9422

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 28, 2021

I wonder if we can use some is_R_or_C/scalar_tower magic to unify
these lemmas with has_*deriv*_at.cexp and has_*deriv*_at.clog.

Open in Gitpod

@urkud
feat(analysis/special_functions): real derivs of complex.exp and `c…
ff2c7cf 
…omplex.log`

I wonder if we can use some `is_R_or_C`/`scalar_tower` magic to unify
these lemmas with `has_*deriv*_at.cexp` and `has_*deriv*_at.clog`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Sep 28, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 30, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 1, 2021
@urkud urkud mentioned this pull request Oct 1, 2021
Closed
1 task
@jcommelin
Copy link
Member

jcommelin commented Oct 2, 2021 •
edited

Is this going to conflict with #9501 ?

@urkud @jcommelin
Update src/analysis/complex/basic.lean
833386b 
Co-authored-by: Johan Commelin <johan@commelin.net>
@urkud
Copy link
Member Author

urkud commented Oct 2, 2021

Is this going to conflict with #9501 ?

It shouldn't: this PR is all about derivatives, not about continuity.

jcommelin
jcommelin approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 4, 2021
bors bot pushed a commit that referenced this pull request Oct 4, 2021
@urkud
feat(analysis/special_functions): real derivs of complex.exp and `c…
a5c5fe8 
…omplex.log` (#9422)
@bors
Copy link

bors bot commented Oct 4, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 4, 2021
@urkud
feat(analysis/special_functions): real derivs of complex.exp and `c…
b6f94a9 
…omplex.log` (#9422)
@bors
Copy link

bors bot commented Oct 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions): real derivs of complex.exp and complex.log [Merged by Bors] - feat(analysis/special_functions): real derivs of complex.exp and complex.log Oct 4, 2021
@bors bors bot closed this Oct 4, 2021
@bors bors bot deleted the deriv-complex-to-real branch October 4, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @sgouezel