[Merged by Bors] - feat(analysis/convex/function): helper lemmas and general cleanup #9438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
2 tasks
|
Can you summarize what the generalizations to the instances are in the PR description? |
eric-wieser
reviewed
Sep 29, 2021
src/analysis/convex/basic.lean
Outdated
| @@ -423,6 +423,21 @@ begin | |||
| exact h hx hy ha hb hab | |||
| end | |||
|
|
|||
| lemma convex_iff_forall_pos_ne : | |||
There was a problem hiding this comment.
Is there any point keeping convex_iff_forall_pos around? Either you need the strong forward direction, which is just rw convex, or you need the strong backwards direction, which is rw <-convex_iff_forall_pos_ne. I think having an intermediate strength version is unecessary.
There was a problem hiding this comment.
I think it's fine to keep? We can nuke it later if we want to.
eric-wieser
reviewed
Sep 29, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
|
Thanks π bors d+ (Please merge after updating the PR description following Eric's remark.) |
|
βοΈ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
) This adds * `convex_iff_pairwise_on_pos` * `convex_on_iff_forall_pos`, `concave_on_iff_forall_pos`, * `convex_on_iff_forall_pos_ne`, `concave_on_iff_forall_pos_ne` * `convex_on.convex_strict_epigraph`, `concave_on.convex_strict_hypograph` generalizes some instance assumptions: * `convex_on.translate_` didn't need `module π Ξ²` but `has_scalar π Ξ²`. * some proofs in `analysis.convex.exposed` were vestigially using `β`. and golfs proofs.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
) This adds * `convex_iff_pairwise_on_pos` * `convex_on_iff_forall_pos`, `concave_on_iff_forall_pos`, * `convex_on_iff_forall_pos_ne`, `concave_on_iff_forall_pos_ne` * `convex_on.convex_strict_epigraph`, `concave_on.convex_strict_hypograph` generalizes some instance assumptions: * `convex_on.translate_` didn't need `module π Ξ²` but `has_scalar π Ξ²`. * some proofs in `analysis.convex.exposed` were vestigially using `β`. and golfs proofs.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
) This adds * `convex_iff_pairwise_on_pos` * `convex_on_iff_forall_pos`, `concave_on_iff_forall_pos`, * `convex_on_iff_forall_pos_ne`, `concave_on_iff_forall_pos_ne` * `convex_on.convex_strict_epigraph`, `concave_on.convex_strict_hypograph` generalizes some instance assumptions: * `convex_on.translate_` didn't need `module π Ξ²` but `has_scalar π Ξ²`. * some proofs in `analysis.convex.exposed` were vestigially using `β`. and golfs proofs.
|
Build failed (retrying...): |
|
bors r- |
|
βοΈ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
jcommelin
added
the
awaiting-CI
sgouezel
added
awaiting-author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 2, 2021
) This adds * `convex_iff_pairwise_on_pos` * `convex_on_iff_forall_pos`, `concave_on_iff_forall_pos`, * `convex_on_iff_forall_pos_ne`, `concave_on_iff_forall_pos_ne` * `convex_on.convex_strict_epigraph`, `concave_on.convex_strict_hypograph` generalizes some instance assumptions: * `convex_on.translate_` didn't need `module π Ξ²` but `has_scalar π Ξ²`. * some proofs in `analysis.convex.exposed` were vestigially using `β`. and golfs proofs.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 3, 2021
) This adds * `convex_iff_pairwise_on_pos` * `convex_on_iff_forall_pos`, `concave_on_iff_forall_pos`, * `convex_on_iff_forall_pos_ne`, `concave_on_iff_forall_pos_ne` * `convex_on.convex_strict_epigraph`, `concave_on.convex_strict_hypograph` generalizes some instance assumptions: * `convex_on.translate_` didn't need `module π Ξ²` but `has_scalar π Ξ²`. * some proofs in `analysis.convex.exposed` were vestigially using `β`. and golfs proofs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
convex_iff_pairwise_on_posconvex_on_iff_forall_pos,concave_on_iff_forall_pos,convex_on_iff_forall_pos_ne,concave_on_iff_forall_pos_neconvex_on.convex_strict_epigraph,concave_on.convex_strict_hypographgeneralizes some instance assumptions:
convex_on.translate_didn't needmodule π Ξ²buthas_scalar π Ξ².analysis.convex.exposedwere vestigially usingβ.and golfs proofs.
This is preparatory work for #9437.