Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory): quotients of a noetherian ring are noetherian #9449

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(ring_theory): quotients of a noetherian ring are noetherian #9449

wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

Open in Gitpod

@Vierkantor Vierkantor added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Sep 29, 2021
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Sep 30, 2021
@Vierkantor Vierkantor added awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 1, 2021
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Oct 1, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Oct 1, 2021
@semorrison semorrison removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 2, 2021
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 2, 2021
bors bot pushed a commit that referenced this pull request Oct 2, 2021
@Vierkantor
feat(ring_theory): quotients of a noetherian ring are noetherian (#9449)
daf54c8 


Co-authored-by: Anne Baanen <t.baanen@vu.nl>
@bors
Copy link

bors bot commented Oct 2, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Oct 2, 2021
@Vierkantor
feat(ring_theory): quotients of a noetherian ring are noetherian (#9449)
a59876f 


Co-authored-by: Anne Baanen <t.baanen@vu.nl>
@bors
Copy link

bors bot commented Oct 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory): quotients of a noetherian ring are noetherian [Merged by Bors] - feat(ring_theory): quotients of a noetherian ring are noetherian Oct 2, 2021
@bors bors bot closed this Oct 2, 2021
@bors bors bot deleted the quotient_is_noetherian branch October 2, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-for-bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vierkantor @jcommelin @eric-wieser @semorrison