[Merged by Bors] - feat(data/polynomial,field_theory): (minpoly A x).map f ≠ 1
#9451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this result to generalize `minpoly.not_is_unit` from integral domains to nontrivial `comm_ring`s.
Vierkantor
added
the
awaiting-review
jcommelin
reviewed
Sep 30, 2021
semorrison
added
awaiting-author
Co-authored-by: Johan Commelin <johan@commelin.net>
Vierkantor
added
awaiting-review
|
Thanks 🎉 bors d+ |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
jcommelin
added
awaiting-CI
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
Vierkantor
removed
the
awaiting-CI
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
We use this result to generalize `minpoly.not_is_unit` from integral domains to nontrivial `comm_ring`s. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
We use this result to generalize `minpoly.not_is_unit` from integral domains to nontrivial `comm_ring`s. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
(minpoly A x).map f ≠ 1(minpoly A x).map f ≠ 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this result to generalize
minpoly.not_is_unitfrom integral domains to nontrivialcomm_rings.