Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/free_module/strong_rank_condition): add comm_ring_strong_rank_condition #9486

Closed
wants to merge 34 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/free_module/strong_rank_condition): add comm_ring_strong_rank_condition #9486

wants to merge 34 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Oct 1, 2021 •
edited by github-actions bot

We add comm_ring_strong_rank_condition: any commutative ring satisfies the strong rank condition.

Because of a circular import, this can't be in linear_algebra.invariant_basis_number.

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Oct 1, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 1, 2021
riccardobrasca and others added 2 commits October 1, 2021 17:02
@riccardobrasca @eric-wieser
Update src/linear_algebra/free_module/strong_rank_condition.lean
a5c1551 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@riccardobrasca
doc
9e0ac93
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 2, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 2, 2021
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@semorrison
Copy link
Collaborator

What was the purpose of moving the contents of charpoly/to_matrix.lean into charpoly/basic.lean? It seems counterproductive.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 4, 2021
riccardobrasca and others added 3 commits October 4, 2021 08:03
@riccardobrasca @semorrison
Update src/linear_algebra/invariant_basis_number.lean
5fcab9c 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@riccardobrasca @semorrison
Update src/linear_algebra/free_module/strong_rank_condition.lean
5cde22d 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@riccardobrasca @semorrison
Update src/linear_algebra/free_module/strong_rank_condition.lean
8eb0fde 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@riccardobrasca
Copy link
Member Author

I did it since charpoly_to_matrix is a basic fact about the characteristic polynomial. But indeed in practice one probably doesn't need it and it makes sense to have in a separate file to avoid importing linear_algebra.invariant_basis_number.

@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 4, 2021
@bors
Copy link

bors bot commented Oct 4, 2021

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

jcommelin
jcommelin approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@jcommelin jcommelin added awaiting-CI The author would like to see what CI has to say before doing more work. ready-for-bors labels Oct 4, 2021
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 4, 2021
@riccardobrasca riccardobrasca removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Oct 4, 2021
@riccardobrasca
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 4, 2021
@riccardobrasca
feat(linear_algebra/free_module/strong_rank_condition): add `comm_rin…
dc1b045 
…g_strong_rank_condition` (#9486)

We add `comm_ring_strong_rank_condition`: any commutative ring satisfies the strong rank condition.

Because of a circular import, this can't be in `linear_algebra.invariant_basis_number`.
@bors
Copy link

bors bot commented Oct 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/free_module/strong_rank_condition): add comm_ring_strong_rank_condition [Merged by Bors] - feat(linear_algebra/free_module/strong_rank_condition): add comm_ring_strong_rank_condition Oct 4, 2021
@bors bors bot closed this Oct 4, 2021
@bors bors bot deleted the RB_strong_rank_comm branch October 4, 2021 09:48
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@semorrison semorrison semorrison left review comments

@sgouezel sgouezel sgouezel left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-for-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@riccardobrasca @semorrison @eric-wieser @jcommelin @sgouezel