Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(ring_theory/unique_factorization_domain): rename unique_factorization_monoid.factors #9503

Closed
wants to merge 6 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

This frees up the name for the non-normalizing version.


See #9443.

Open in Gitpod

src/ring_theory/dedekind_domain.lean Outdated Show resolved Hide resolved
src/ring_theory/dedekind_domain.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 2, 2021
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 3, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 3, 2021
bors bot pushed a commit that referenced this pull request Oct 3, 2021
…orization_monoid.factors (#9503)

This frees up the name for the non-normalizing version.
@bors
Copy link

bors bot commented Oct 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(ring_theory/unique_factorization_domain): rename unique_factorization_monoid.factors [Merged by Bors] - refactor(ring_theory/unique_factorization_domain): rename unique_factorization_monoid.factors Oct 3, 2021
@bors bors bot closed this Oct 3, 2021
@bors bors bot deleted the rename-factors branch October 3, 2021 13:54
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants