Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - split(order/monotone): split off order.basic #9518

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - split(order/monotone): split off order.basic #9518

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Oct 3, 2021
bryangingechen
bryangingechen approved these changes Oct 3, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Thanks!
bors d+

src/order/monotone.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 3, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 3, 2021
@YaelDillies @bryangingechen
swap monotone and antitone
186a2f0 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 3, 2021
@YaelDillies
split(order/monotone): split off order.basic (#9518)
465508f
@bors
Copy link

bors bot commented Oct 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(order/monotone): split off order.basic [Merged by Bors] - split(order/monotone): split off order.basic Oct 3, 2021
@bors bors bot closed this Oct 3, 2021
@bors bors bot deleted the split_mono branch October 3, 2021 22:32
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @bryangingechen @eric-wieser