Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/padics): add padic_norm lemmas #9527

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(number_theory/padics): add padic_norm lemmas #9527

wants to merge 2 commits into from

Conversation

mariainesdff
Copy link
Collaborator

Open in Gitpod

@mariainesdff mariainesdff added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 4, 2021
ocfnash
ocfnash reviewed Oct 4, 2021
View reviewed changes
src/number_theory/padics/padic_numbers.lean Outdated
Comment on lines 1047 to 1048
lemma norm_lt_pow_iff_norm_le_pow_sub_one (x : ℚ_[p])
(n : ℤ) : ∥x∥ < p ^ n ↔ ∥x∥ ≤ p ^ (n - 1) :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma norm_lt_pow_iff_norm_le_pow_sub_one (x : ℚ_[p])
(n : ℤ) : ∥x∥ < p ^ n ↔ ∥x∥ ≤ p ^ (n - 1) :=
lemma norm_lt_pow_iff_norm_le_pow_sub_one (x : ℚ_[p]) (n : ℤ) :
∥x∥ < p ^ n ↔ ∥x∥ ≤ p ^ (n - 1) :=

@ocfnash
Copy link
Collaborator

ocfnash commented Oct 4, 2021

bors d+

@bors
Copy link

bors bot commented Oct 4, 2021

✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 4, 2021
@mariainesdff
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 4, 2021
@mariainesdff
feat(number_theory/padics): add padic_norm lemmas (#9527)
2c03e74
@bors
Copy link

bors bot commented Oct 4, 2021

Build failed:

@bryangingechen
Copy link
Collaborator

Seems to be a spurious failure.
bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 4, 2021
bors bot pushed a commit that referenced this pull request Oct 5, 2021
@mariainesdff
feat(number_theory/padics): add padic_norm lemmas (#9527)
7466424
@bors
Copy link

bors bot commented Oct 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/padics): add padic_norm lemmas [Merged by Bors] - feat(number_theory/padics): add padic_norm lemmas Oct 5, 2021
@bors bors bot closed this Oct 5, 2021
@bors bors bot deleted the padic_norm branch October 5, 2021 02:08
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mariainesdff @ocfnash @bryangingechen @eric-wieser